New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for setting up encrypted samsung tvs from config flow #68717
Conversation
A reauth flow is no longer required to detect the need for encryption as it can now be detected during setup Fixes being able to setup legacy TVs since the encrypted check previously would prevent them from proceeding Improves the failure case where the user cannot hit the button to allow Home Assistant connect to the TV in time by allowing them to retry
Hey there @chemelli74, @epenet, mind taking a look at this pull request as it has been labeled with an integration ( |
When we add the additional SSDP location we can use something similar to what shelly does for the reload race
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
Noticed this after, but |
Split from #68663
Proposed change
A reauth flow is no longer required to detect the need for
encryption as it can now be detected during setup
Fixes being able to setup legacy TVs since the encrypted
check previously would prevent them from proceeding
Improves the failure case where the user cannot hit
the button to allow Home Assistant connect to the TV
in time by allowing them to retry
Fixes a case where we were patching the integration
SamsungTVLegacyBridge.async_try_connect
insteadof the library
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: