Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Somfy integration #73527

Merged
merged 2 commits into from Jun 15, 2022
Merged

Conversation

tetienne
Copy link
Contributor

@tetienne tetienne commented Jun 15, 2022

Breaking change

As announced with the latest release, Somfy will shutdown its Open API the June 21st. This鈥疨R removes everything related to the associated component.

image

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Jun 15, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jun 15, 2022
Copy link
Contributor

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃槶. Thanks for all your work on the integration! And happy to see your continued work on the Overkiz integration.

And since it has been deprecated in last update, it can safely be removed.

The Somfy integration is deprecated and will be removed in Home Assistant Core 2022.7; due to the Somfy Open API deprecation.

@tetienne
Copy link
Contributor Author

@iMicknl It was my first integration, I鈥檓 a little emotive :)

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Dev automation moved this from By Code Owner to Reviewer approved Jun 15, 2022
@MartinHjelmare MartinHjelmare merged commit 658ce9d into home-assistant:dev Jun 15, 2022
Dev automation moved this from Reviewer approved to Done Jun 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants