New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
P1 Monitor add water meter support #74004
Merged
frenck
merged 10 commits into
home-assistant:dev
from
klaasnicolaas:klaas/p1mon-watermeter
Aug 18, 2022
Merged
P1 Monitor add water meter support #74004
frenck
merged 10 commits into
home-assistant:dev
from
klaasnicolaas:klaas/p1mon-watermeter
Aug 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaasnicolaas
force-pushed
the
klaas/p1mon-watermeter
branch
from
June 26, 2022 10:20
03239a9
to
48c993f
Compare
frenck
reviewed
Jul 9, 2022
klaasnicolaas
force-pushed
the
klaas/p1mon-watermeter
branch
from
August 14, 2022 00:58
48c993f
to
849d79d
Compare
klaasnicolaas
force-pushed
the
klaas/p1mon-watermeter
branch
from
August 14, 2022 01:41
849d79d
to
cb1509f
Compare
8 tasks
frenck
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @klaasnicolaas 馃憤
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Because I changed the way of creating entities in
sensor.py
, entity_id has added a service name.Proposed change
This PR adds the option to read the water meter from P1 Monitor, it is optional because not everyone is using it. Python package changelog: https://github.com/klaasnicolaas/python-p1monitor/releases/tag/v2.0.0
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: