Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Notion to new entity naming style #74746

Merged
merged 3 commits into from Jul 10, 2022

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Jul 8, 2022

Proposed change

This PR migrates the Notion integration to the new entity naming style.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@bachya bachya self-assigned this Jul 8, 2022
@project-bot project-bot bot added this to Needs review in Dev Jul 8, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jul 8, 2022
Dev automation moved this from By Code Owner to Reviewer approved Jul 8, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this integration uses title case style naming in the names of entity descriptions. The new styling also should make all of these sentence case.

Dev automation moved this from Reviewer approved to Review in progress Jul 9, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bachya 馃憤

Dev automation moved this from Review in progress to Reviewer approved Jul 10, 2022
@frenck frenck merged commit edf3047 into home-assistant:dev Jul 10, 2022
Dev automation moved this from Reviewer approved to Done Jul 10, 2022
@bachya bachya deleted the notion-entity-name branch July 10, 2022 19:42
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants