Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stored philips_js system data on start #75981

Merged
merged 4 commits into from Aug 5, 2022

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Jul 31, 2022

Proposed change

To make sure we know supported features of TV on startup, even
when unavailable. Use the config entry system data and update it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

To make sure we know supported features of TV on startup, even
when unavailable. Use the config entry system data and update it.
@elupus elupus changed the title Use stored system data on start Use stored philips_js system data on start Jul 31, 2022
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@elupus
Copy link
Contributor Author

elupus commented Aug 5, 2022

After a few releases of this we should be able to drop the optional system, since now all entries will end up having one.

@MartinHjelmare MartinHjelmare merged commit a0ef3ad into home-assistant:dev Aug 5, 2022
@MartinHjelmare
Copy link
Member

Tag for patch release?

@elupus elupus deleted the philips_js/system branch August 5, 2022 14:16
@elupus
Copy link
Contributor Author

elupus commented Aug 5, 2022

Yup

@elupus elupus added this to the 2022.8.2 milestone Aug 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambilight+Hue is not detected correctly in Philips TV integration
4 participants