New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for restoring HomeKit IIDs #79913
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
Probably need some unit tests for the iid manager like we do for the aid manager as it would be good to test that implementation directly |
balloob
reviewed
Oct 14, 2022
balloob
approved these changes
Oct 14, 2022
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs ikalchev/HAP-python#423Breaking change
HomeKit instance ID assignments are now stable between restarts to comply with the HomeKit specifications. This prevents accessories from loosing track of services between restarts, and improves stability with using Siri especially with apple watches.
This change may dramatically improve the stability and re-sync times of
media_player
entities (all),camera
entities (all),fan
entities (presets),remote
entities (activity ones),switch
entities (power strips), triggers (all) between restarts which was especially apparent when the home has many accessories.As with #35691, because the assignments were previously unstable, it may be necessary to do a one time adjustment of accessory room assignments, favorites, or re-pair camera accessories after upgrading.
Proposed change
Currently we rely on creation order to keep iids the same but this is not reliable since services and chars can change.
Fixes #78092
Fixes #77514
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: