Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MQTT type hints part 5 #80979

Merged
merged 10 commits into from Nov 8, 2022
Merged

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Oct 25, 2022

Proposed change

Improve type annotation for MQTT modules:

  • scene
  • select
  • sensor

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the issue, add the integration domain after the command.

@jbouwh
Copy link
Contributor Author

jbouwh commented Oct 25, 2022

This PR is a follow up on: #80913

homeassistant/components/mqtt/select.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/select.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/sensor.py Outdated Show resolved Hide resolved
@epenet
Copy link
Contributor

epenet commented Nov 7, 2022

scene/select look good.
sensor is waiting on Sentinel: #81553

@epenet epenet marked this pull request as draft November 7, 2022 07:55
@jbouwh jbouwh force-pushed the mqtt-typing-#5 branch 2 times, most recently from 68881bb to f3f5eac Compare November 7, 2022 12:19
@jbouwh jbouwh marked this pull request as ready for review November 7, 2022 14:23
homeassistant/components/mqtt/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/sensor.py Outdated Show resolved Hide resolved
jbouwh and others added 2 commits November 8, 2022 10:15
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thanks @jbouwh 👍

@epenet epenet merged commit 47dba6f into home-assistant:dev Nov 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
@jbouwh jbouwh deleted the mqtt-typing-#5 branch September 8, 2023 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants