Allow None return for notify get_service

[cdce8p]

Proposed change

Modify protocol typing for LegacyNotifyPlatform to allow None return for async_get_service and get_service. This is fully handled by the existing code and integrations frequently return None, e.g. if the discovery_info is None.

core/homeassistant/components/notify/legacy.py

Lines 85 to 98 in 32f3eb7

	notify_service = None
	try:
	if hasattr(platform, "async_get_service"):
	notify_service = await platform.async_get_service(
	hass, p_config, discovery_info
	)
	elif hasattr(platform, "get_service"):
	notify_service = await hass.async_add_executor_job(
	platform.get_service, hass, p_config, discovery_info
	)
	else:
	raise HomeAssistantError("Invalid notify platform.")
	if notify_service is None:

core/homeassistant/components/discord/notify.py

Lines 41 to 49 in 32f3eb7

	async def async_get_service(
	hass: HomeAssistant,
	config: ConfigType,
	discovery_info: DiscoveryInfoType | None = None,
	) -> DiscordNotificationService | None:
	"""Get the Discord notification service."""
	if discovery_info is None:
	return None
	return DiscordNotificationService(hass, discovery_info[CONF_API_TOKEN])

The custom pylint plugin does also use the correct return type already.

core/pylint/plugins/hass_enforce_type_hints.py

Lines 390 to 401 in 32f3eb7

	"notify": [
	TypeHintMatch(
	function_name="get_service",
	arg_types={
	0: "HomeAssistant",
	1: "ConfigType",
	2: "DiscoveryInfoType | None",
	},
	return_type=["BaseNotificationService", None],
	check_return_type_inheritance=True,
	has_async_counterpart=True,
	),

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (notify) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of notify can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Change the title of the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign notify Removes the current integration label and assignees on the issue, add the integration domain after the command.

[epenet]

Looks good!
Thanks @cdce8p 👍