Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lupupy dependency to v0.2.3 #83765

Merged
merged 1 commit into from Dec 14, 2022
Merged

Conversation

majuss
Copy link
Contributor

@majuss majuss commented Dec 11, 2022

Proposed change

majuss/lupupy@4dbd888...v0.2.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@majuss
Copy link
Contributor Author

majuss commented Dec 13, 2022

@MartinHjelmare could you please have a look at this? I don't really understand the output. The test which validates the config options failed?

@frenck
Copy link
Member

frenck commented Dec 13, 2022

@majuss The test failure is not related. I've restarted the failing job.

As for the version bump, can we please tag the version on the GitHub repository of the package source code? Preferably using the releases feature on GitHub.

That would give everybody a better insight into what changed between versions.

../Frenck

@majuss
Copy link
Contributor Author

majuss commented Dec 14, 2022

The pipeline failed again :/

I created a lupupy release.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @majuss 👍

@frenck frenck added this to the 2022.12.6 milestone Dec 14, 2022
@frenck frenck changed the title Bump lupupy dependency Bump lupupy dependency to v0.2.3 Dec 14, 2022
@frenck frenck merged commit e16b874 into home-assistant:dev Dec 14, 2022
balloob pushed a commit that referenced this pull request Dec 14, 2022
@balloob balloob mentioned this pull request Dec 14, 2022
Hadatko pushed a commit to Hadatko/core that referenced this pull request Dec 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2022
@majuss majuss deleted the lupupy-bump branch December 19, 2022 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lupusec component returning error with __init__.py
4 participants