Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow None connector for BaseHaRemoteScanner #84847

Merged
merged 1 commit into from Dec 30, 2022

Conversation

akx
Copy link
Contributor

@akx akx commented Dec 30, 2022

Proposed change

BaseHaRemoteScanner's superclass BaseHaScanner allows connector to be None, but the subclass doesn't.

I'm implementing support for a decidedly non-connectable, polling remote scanner.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (bluetooth) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of bluetooth can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign bluetooth Removes the current integration label and assignees on the issue, add the integration domain after the command.

@akx akx mentioned this pull request Dec 30, 2022
20 tasks
@bdraco bdraco merged commit 7440c34 into home-assistant:dev Dec 30, 2022
kvanzuijlen pushed a commit to kvanzuijlen/core that referenced this pull request Dec 30, 2022
kvanzuijlen pushed a commit to kvanzuijlen/core that referenced this pull request Dec 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants