Add free_ebikes attribute to citybikes provider sensor - #85279
Closed
mxr wants to merge 2 commits into
Closed
Conversation
Contributor
|
Hi mxr It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
| {vol.Optional(ATTR_UID): cv.string}, extra=vol.REMOVE_EXTRA | ||
| { | ||
| vol.Optional(ATTR_UID): cv.string, | ||
| vol.Optional(ATTR_FREE_EBIKES): cv.positive_int, |
Member
There was a problem hiding this comment.
This integration is missing a library for the interface and data parsing code. We won't allow changes to this integration that involves that part of the code until it's been refactored to use a 3rd party library.
Please extract the device specific interface code and data parsing to a standalone library published on PyPI.
Member
|
Since a different approach is needed, I'll close the PR now. Thanks for your willingness to contribute! |
Contributor
Author
|
Understood, thanks for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This is a reimplementation of #82945. It adds the amount of free e-bikes to the sensor attributes. The reason it uses the attributes instead of creating a new sensor is to be consistent with where the other secondary values are stored (number of empty slots, etc).
The free ebikes value comes from the extras. For example:
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: