Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Starlink reboot button #85729

Merged
merged 5 commits into from Jan 16, 2023
Merged

Conversation

boswelja
Copy link
Contributor

@boswelja boswelja commented Jan 12, 2023

Proposed change

Adding the button platform to Starlink, which allows users to reboot their starlink system from homeassistant.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@boswelja boswelja marked this pull request as ready for review January 13, 2023 04:06
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-01-15 at 9 17 53 PM

Screenshot 2023-01-15 at 9 17 47 PM

Tested 👍

@bdraco
Copy link
Member

bdraco commented Jan 16, 2023

Unrelated to this PR, but are the units for elevation correct?

@bdraco bdraco merged commit 8c23535 into home-assistant:dev Jan 16, 2023
@boswelja
Copy link
Contributor Author

Unrelated to this PR, but are the units for elevation correct?

It is documented as "elevation, in degrees", but since these aren't official docs from Starlink themselves it could be wrong. Do you suspect something is amiss?

@boswelja boswelja deleted the feature/starlink-buttons branch January 16, 2023 23:04
@bdraco
Copy link
Member

bdraco commented Jan 16, 2023

Unrelated to this PR, but are the units for elevation correct?

It is documented as "elevation, in degrees", but since these aren't official docs from Starlink themselves it could be wrong. Do you suspect something is amiss?

I would expect it to be called Altitude since it's in degrees but after digging in, Starlink calls it that so seems fine. Just an unexpected choice... but so is the Wi-Fi ap name

@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants