Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability to ignore coverage violations #86597

Merged
merged 3 commits into from Jan 25, 2023

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Jan 25, 2023

Proposed change

Remove ability to ignore coverage violations

Loosely based on #86534, this ensure that platforms we defined as "needs coverage" cannot be ignored.

Note: this will likely result in a slight drop of overall coverage.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Jan 25, 2023
@emontnemery
Copy link
Contributor

Do we need to adjust the coverage target for codecov/project/required?

@epenet
Copy link
Contributor Author

epenet commented Jan 25, 2023

Do we need to adjust the coverage target for codecov/project/required?

I used the same settings as config-flow.
Isn't the objective 100% ?

@epenet
Copy link
Contributor Author

epenet commented Jan 25, 2023

Note: codecov/project/required is set to auto, and it's the first time it's being implemented so the failure is expected.
From now on, we would expect coverage to only go up for required...

@epenet
Copy link
Contributor Author

epenet commented Jan 25, 2023

cc @frenck / @MartinHjelmare / @thecode based on discussion on Discord.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@MartinHjelmare ?

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@epenet epenet merged commit b2004e6 into home-assistant:dev Jan 25, 2023
@epenet epenet deleted the enforce-DONT_IGNORE branch January 25, 2023 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants