Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanups to writing entity state #89890

Merged
merged 5 commits into from Mar 18, 2023
Merged

Small cleanups to writing entity state #89890

merged 5 commits into from Mar 18, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 17, 2023

Noticed while looking at the profiles from #89408

Proposed change

  • Make friendly_name a bound method since it has no closure variables
  • Remove duplicate local variables for self.registry_entry
  • Avoid two dict lookups when DATA_CUSTOMIZE is in hass.data
  • Reduce one possible access of self.name in broken out _friendly_name
  • Save a few attribute lookups of self.entity_id

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco marked this pull request as ready for review March 17, 2023 20:02
@bdraco bdraco requested a review from a team as a code owner March 17, 2023 20:02
@balloob balloob merged commit 30e7ab2 into dev Mar 18, 2023
52 checks passed
@balloob balloob deleted the state_write_cleanups branch March 18, 2023 00:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants