Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lingering timers in bluetooth (part 1) #91673

Merged
merged 2 commits into from Apr 20, 2023

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Apr 19, 2023

Proposed change

Linked to #91360
https://github.com/home-assistant/core/actions/runs/4729883045/jobs/8393069269?pr=91360

ERROR tests/components/bluetooth/test_init.py::test_discover_new_usb_adapters - Failed: Lingering timer after job <Job call_later 125 HassJobType.Coroutinefunction <function async_setup.<locals>._async_call_debouncer at 0x7fe6bfaad5a0>>
ERROR tests/components/bluetooth/test_init.py::test_discover_new_usb_adapters_with_firmware_fallback_delay - Failed: Lingering timer after test <TimerHandle when=879.731116588 Debouncer._on_debounce() created at /home/runner/work/core/core/homeassistant/helpers/debounce.py:149>

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (bluetooth) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of bluetooth can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign bluetooth Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@@ -220,7 +226,7 @@ def _async_trigger_discovery() -> None:
async_call_later(
hass,
BLUETOOTH_DISCOVERY_COOLDOWN_SECONDS + LINUX_FIRMWARE_LOAD_FALLBACK_SECONDS,
_async_call_debouncer,
HassJob(_async_call_debouncer, cancel_on_shutdown=True),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe save the job in a local var so it doesn't get recreated every time?

@epenet epenet merged commit 62d38b4 into home-assistant:dev Apr 20, 2023
54 checks passed
@epenet epenet deleted the bluetooth-lingering-timers branch April 20, 2023 16:07
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants