Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn AVM FRITZ!Box Tools call deflection switches into coordinator entities #91913

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Apr 23, 2023

Proposed change

This reduces the API calls, prior each existing call deflection caused one API call to fetch all deflections and filter to the current one, now all call deflections are get by the coordinator once and each call deflection entity use the data from coordinator. If there are about 20 existing call deflections, only 1 call is made as opposed to 20 before.

This is also the pre-work for migrating the other switch (port forwarding, wifi and profile) entities.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @mammuth, @AaronDavidSchneider, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (fritz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fritz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign fritz Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@mib1185 mib1185 force-pushed the fritz/migrate-switch-entities-to-coordinator-entities branch from d74644b to 123cf30 Compare April 23, 2023 19:39
@mib1185 mib1185 added this to the 2023.5.0 milestone Apr 26, 2023
homeassistant/components/fritz/common.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 27, 2023 09:52
@mib1185 mib1185 marked this pull request as ready for review April 27, 2023 10:47
homeassistant/components/fritz/switch.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft April 29, 2023 16:01
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@mib1185 mib1185 marked this pull request as ready for review April 29, 2023 16:09
@home-assistant home-assistant bot requested a review from frenck April 29, 2023 16:09
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mib1185 👍

../Frenck

@frenck frenck dismissed chemelli74’s stale review April 29, 2023 16:51

Comment was addressed

@frenck frenck merged commit ac4d921 into home-assistant:dev Apr 29, 2023
24 checks passed
@mib1185
Copy link
Contributor Author

mib1185 commented Apr 29, 2023

Thanks for your review @frenck , now take a break and enjoy your holiday 🍻

@mib1185 mib1185 deleted the fritz/migrate-switch-entities-to-coordinator-entities branch April 29, 2023 16:52
frenck added a commit that referenced this pull request Apr 29, 2023
…tities (#91913)

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update of switch.fritz_box_7590_call_deflection_23 is taking over 10 seconds
3 participants