Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mqtt not available when starting snips #92296

Merged
merged 1 commit into from Apr 30, 2023
Merged

Fix mqtt not available when starting snips #92296

merged 1 commit into from Apr 30, 2023

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Apr 30, 2023 •
edited

Proposed change

Snips depends on MQTT but it seems the snips integration setup can occur before the mqtt client is set up. The check added will wait for the mqtt client to be set up. Further investigation is desired to find out why mqtt is not available yet as it should because of the dependency.

This is a regression after change: #91790
Before that change we had a different check that awaited the entry to be started up:
#81733

That approach worked before, but that is strange as snips should wait for mqtt because it set as a dependency.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@jbouwh jbouwh added this to the 2023.5.0 milestone Apr 30, 2023
@jbouwh jbouwh merged commit 7a43b29 into home-assistant:dev Apr 30, 2023
24 checks passed
@jbouwh jbouwh deleted the snips-startup branch April 30, 2023 15:35
@jbouwh jbouwh mentioned this pull request Apr 30, 2023
Closed
frenck pushed a commit that referenced this pull request Apr 30, 2023
@jbouwh @frenck
Fix mqtt not available when starting snips (#92296)
2b2be6a
raman325 added a commit to raman325/home-assistant that referenced this pull request Apr 30, 2023
@raman325
Merge branch 'dev' into datetime_2
19246c7 
* dev: (581 commits)
  Only store and pass around coordinator in Rituals Perfume Genie (home-assistant#92298)
  Avoid returning statistics columns that the metadata knows are impossible (home-assistant#92095)
  Add `date` platform (home-assistant#81948)
  Prevent pysnmp from being installed as it does not work with newer python (home-assistant#92292)
  Use SnapshotAssertion in Renault tests (home-assistant#90778)
  Home Connect add WasherDryer support (home-assistant#90673)
  Move lastfm constants to separate file (home-assistant#92289)
  Fix august lock state when API reports locking and locked with the same timestamp (home-assistant#92276)
  Ensure onvif webhook can be registered (home-assistant#92295)
  Bump beacontools to fix conflict with construct<2.10 and >=2.8.16 (home-assistant#92293)
  Bump pynina to 0.3.0 (home-assistant#92286)
  Fix mqtt not available when starting snips (home-assistant#92296)
  Extract Rituals Perfume Genie DataUpdateCoordinator into module (home-assistant#92284)
  Bump bleak to 0.20.2 (home-assistant#92294)
  Add missing fstrings in Local Calendar (home-assistant#92288)
  Remove myself from switcher_kis codeowners (home-assistant#92277)
  Handle AttributeError from wrong port in ONVIF config flow (home-assistant#92272)
  Auto repair incorrect collation on MySQL schema (home-assistant#92270)
  Update orjson to 3.8.11 (home-assistant#92228)
  Update coverage to 7.2.4 (home-assistant#92229)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
bugfix cherry-picked cla-signed has-tests integration: snips Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2023.5.0
Development

Successfully merging this pull request may close these issues.

snips can not be setup after update to core-2023.5.0b2
3 participants
@jbouwh @bdraco @frenck