Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duckdns: add option to grab IP addresses from URLs #1077

Merged
merged 4 commits into from Feb 21, 2020

Conversation

@scop
Copy link
Contributor

scop commented Feb 15, 2020

Enables use of external services instead of Duck DNS' automatic detection, which at time of writing doesn't work with IPv6: https://www.duckdns.org/faqs.jsp

Supersedes #1019. I chose to amend/use the existing ipv4 and ipv6 config options because adding a separate ipvx_manual like suggested there would IMO resulted in clunky config and docs.

Also improves on #892

Enables use of external services instead of Duck DNS' automatic
detection, which at time of writing doesn't work with IPv6.
pvizeli added 3 commits Feb 21, 2020
@pvizeli pvizeli merged commit 5650cea into home-assistant:master Feb 21, 2020
5 checks passed
5 checks passed
addons Build #20200221.7 succeeded
Details
addons (Hadolint) Hadolint succeeded
Details
addons (JQ) JQ succeeded
Details
addons (ShellCheck) ShellCheck succeeded
Details
cla-bot Everyone involved has signed the CLA
@@ -101,14 +100,6 @@ The number of seconds to wait before updating DuckDNS subdomains and renewing Le
- At time of writing, Duck DNS' own IPv6 autodetection
[does not actually work][duckdns-faq], but you can use the URL option
for `ipv6` to get around this, read on.
- IPv6 IP address detection service URLs are likely to not work for the time

This comment has been minimized.

Copy link
@scop

scop Feb 21, 2020

Author Contributor

@pvizeli because this block of text was removed, the "read on" from the previous bullet should be removed too.

This comment has been minimized.

Copy link
@scop

scop Feb 21, 2020

Author Contributor

@pvizeli Also, I fail to see why this block was removed entirely. IPv6 is still not available in the container, so the IPv6 services don't actually work. If you want to remove the file URL stuff, fine, but the rest of the docs that were removed are still valid as far as I can tell.

fetched and used as the address. This enables getting the address from
an external service or from a local `file:/` URL.
fetched and used as the address. This enables getting the address using
a service like https://api6.ipify.org/ or https://ipv6.wtfismyip.com/text

This comment has been minimized.

Copy link
@scop

scop Feb 21, 2020

Author Contributor

@pvizeli I think adding the services here is not a good change. I specifically left them out because they do not actually work. ipv6.wtfismyip.com does not have an IPv4 address so it doesn't work at all without IPv6, and api6.ipify.org returns and IPv4 (!) address when fetched without IPv6 support: rdegges/ipify-api#43. So I think the services should not be mentioned here.

@scop scop deleted the scop:duckdns-ip-from-url branch Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.