Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for notification channels #107

Closed
dshokouhi opened this issue Dec 4, 2019 · 7 comments
Closed

Add support for notification channels #107

dshokouhi opened this issue Dec 4, 2019 · 7 comments
Labels
enhancement New feature or request notifications

Comments

@dshokouhi
Copy link
Member

I know we don't have notifications yet but it would be great if we can add support for notification channels once we do. Its important to differentiate notifications so the user can set the priority and sound. For example you don't want your phone making the same sound for the alarm being triggered as it does for the laundry.

https://developer.android.com/reference/android/app/NotificationChannel

@robbiet480
Copy link
Member

My understanding is that notification channels are static and must be defined in AndroidManifest.xml which means we can't modify it during runtime.

Firebase Cloud Messaging allows defining things like sound and priority on a per notification basis.

@quthla
Copy link
Contributor

quthla commented Dec 4, 2019

Not sure if they can be defined in the manifest but they can definitely be added and modified programmatically.

@dshokouhi
Copy link
Member Author

@quthla yup, my ring app does that as i add/remove ring devices.

@robbiet480
Copy link
Member

My bad, I misread the FCM docs!

@RikP
Copy link

RikP commented Feb 28, 2020

this will also support different messages being able to be send in do not disturb mode.
So same as critical messages on iphone.

@LordBoos
Copy link

LordBoos commented Apr 4, 2020

Even static notification channels would be good. Like 3 channels for priorities like "low", "normal, "critical" so we can customize the channels with different sounds and settings in the android.
I'd like to set up critical notifications for things like "flooded bathroom" that ignore do not disturb mode but at the same time I don't want to low priority notifications like "plant needs water" to wake me up at night.

@dshokouhi
Copy link
Member Author

Closed by #574 currently waiting on home-assistant/mobile-apps-fcm-push#13 to be merged so the feature can work properly. Once its working will get the docs updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request notifications
Projects
None yet
Development

No branches or pull requests

5 participants