New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only ask to re-enable permissions the first time after they are disabled #210

Merged
merged 2 commits into from Feb 14, 2019

Conversation

Projects
None yet
4 participants
@amelchio
Copy link
Member

amelchio commented Feb 4, 2019

I think this is closer to what we discussed in Discord: permissions are now only ensured if the status has changed. So the popups should only show when permissions have just been revoked.

Fixes #177

@robbiet480 robbiet480 merged commit 26bbe92 into home-assistant:master Feb 14, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
@h4nc

This comment has been minimized.

Copy link

h4nc commented Feb 14, 2019

Do we Need or update the iOS App for that and if yes when will we get this update?

@robbiet480

This comment has been minimized.

Copy link
Member

robbiet480 commented Feb 14, 2019

@h4nc This will be in 1.5.1 which I am planning to submit no later than Friday.

@h4nc

This comment has been minimized.

Copy link

h4nc commented Feb 14, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment