Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlabeled buttons #3267

Open
joshms123 opened this issue Jun 12, 2019 · 9 comments

Comments

@joshms123
Copy link

commented Jun 12, 2019

Home Assistant release with the issue:
0.94.1

Last working Home Assistant release (if known):
None

UI (States or Lovelace UI?):
Lovelace

Browser and Operating System:
Chrome, Windows 10

Description of problem:

As a visually impaired user, I have found several accessibility issues over the year or so while using home assistant. The biggest issue currently (of mine at least) is the number of unlabeled buttons in the Lovelace UI. Currently when navigating with my screen reader, I hear "unlabeled 0", "unlabeled 1", etc. With a different screen reader (NVDA), I get even less feedback.
List of unlabeled buttons I know of currently:

  • The button to show the menu bar and developer tools.
  • Notifications button.
  • Button to activate the microphone.
  • Button that shows a menu with unused entities, configure UI and help.
  • Button after that is unknown (nothing noticeable seems to happen).
  • Almost all buttons to control devices are unlabeled apart from execute for scripts, learn more, ARM HOME/AWAY and lock/unlock. I may have missed a few here.
    This is the current list of buttons I have just gone over; if I find more, I will either update or comment.

Javascript errors shown in the web inspector (if applicable):
N/A


Additional information:
N/A

@balloob balloob added this to To do in Frontend via automation Jun 27, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

I have opened a pull request to address a couple of the mentioned missing labels. The pull request is #3310.

@balloob

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

For people looking into helping with this issue, there is an accessibility dev tool to help find bad buttons: https://www.deque.com/axe/.

@steverep

This comment has been minimized.

Copy link

commented Jul 22, 2019

I am a visually impaired user as well and noticed media device buttons, as well as a few others, got labeled in a recent release. Thanks for that.

My cover device cards are not labeled yet though.

I'll point out more as I come across them.

@balloob

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

Opened pull request #3421 to add labels to the cover and cover tilt controls.

@joshms123

This comment has been minimized.

Copy link
Author

commented Jul 24, 2019

Hi there!

Great work on the accessibility fixes so far, I really appreciate it!

The following buttons are unlabeled:

  • On the hass.io tab, when viewing an add-on the back button is unlabeled.
  • When viewing more information in the states view, the close/dismiss button is unlabeled.

The following button from my original post is still unlabeled:

  • Button to activate the menu that shows unused entities, configure UI and help.
@balloob

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

@joshms123 addressed in #3422

@steverep

This comment has been minimized.

Copy link

commented Jul 26, 2019

In the modal dialog when editing an entities card, there are 2 unlabeled buttons associated with each entity in the list. One of them deletes the entity and I'm not sure what the other one does.

@balloob

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

@steverep addressed in #3430

@steverep

This comment has been minimized.

Copy link

commented Jul 27, 2019

Two more:

  • Close button on any modal dialog (e.g. device more info, adding integration, editing view, etc.)
  • When configuring Lovelace UI, button after each card that shows a menu to either move or delete the card
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.