Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Editor is now named {} in UI. #3617

Closed
Petro31 opened this issue Sep 4, 2019 · 7 comments · Fixed by #3968
Closed

Toggle Editor is now named {} in UI. #3617

Petro31 opened this issue Sep 4, 2019 · 7 comments · Fixed by #3968

Comments

@Petro31
Copy link
Contributor

@Petro31 Petro31 commented Sep 4, 2019

Home Assistant release with the issue: 0.98.x

Last working Home Assistant release (if known): Unknown

UI (States or Lovelace UI?): Lovelace

Browser and Operating System: All

Description of problem: Toggle Editor button now has shows {} instead of the words 'Toggle Editor'. Bunch of people on the forums are confused. I agree with them, it's confusing.

Javascript errors shown in the web inspector (if applicable):


Additional information:

@iantrich

This comment has been minimized.

Copy link
Member

@iantrich iantrich commented Sep 26, 2019

Yeah, we're not saving any real estate really with that change. I think we can be even more explicit:
Show YAML Editor/Show UI Editor

@iantrich iantrich added this to To do in Frontend via automation Sep 26, 2019
@iantrich iantrich moved this from To do to Hacktoberfest in Frontend Sep 26, 2019
@SeanPM5

This comment has been minimized.

Copy link
Contributor

@SeanPM5 SeanPM5 commented Sep 28, 2019

I agree with both of you guys, but think it could be further simplified by referring to it as "Visual Editor" and "Code Editor"

I think that is more clear, especially for beginners who might not know the terms "YAML" or "UI" etc.

shmooey added a commit to shmooey/home-assistant-polymer that referenced this issue Oct 9, 2019
@shmooey

This comment has been minimized.

Copy link
Contributor

@shmooey shmooey commented Oct 9, 2019

Hi, I've created a PR #3968 to change the Toggle Editor button from {} to "Show Code Editor / Show Visual Editor".
Let me know how it is!

@ctrl50

This comment has been minimized.

Copy link

@ctrl50 ctrl50 commented Oct 9, 2019

@iantrich

This comment has been minimized.

Copy link
Member

@iantrich iantrich commented Oct 9, 2019

@ctrl50 that is unrelated to button text which is what the subject is here

@ctrl50

This comment has been minimized.

Copy link

@ctrl50 ctrl50 commented Oct 9, 2019

Its related in the fact that the same update caused both issues on the same view. But other than that i know its not the same thing. Lol

@bramkragten

This comment has been minimized.

Copy link
Member

@bramkragten bramkragten commented Oct 9, 2019

@ctrl50 please create a new issue for that, so we can keep track of them.

bramkragten added a commit that referenced this issue Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.