New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set icons for sensors that are in units of degrees #213
Conversation
This also updates the icon rotation direction based on the degrees direction, which means that something like a wind sensor will have an icon which is in a representative direction.
@sdague, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @armills and @robbiet480 to be potential reviewers. |
This is mostly a concept patch to figure out if going down this direction is something that's worth while. Please let me know what you think. |
You can use |
@armills yeh, I could see putting device_class into the sensors infrastructure and selecting on that. Sensors are the things I'm most interested in right now, and I think that actually semantically calling things: "temperature" possibly others. Honestly, if there was a good existing taxonomy would just want to reuse that. That could push a lot of the guessing based on units out of the JS and do this more semantic approach. |
Yep, this is exactly what device_class is for. I don't think we currently have a well defined list of possible classes, but that's what device_class will add. The specific names used will have to be hashed out in the PR. We don't need to come up with a complete list all at once, but once we add a class we should expect it to never change. |
I've been looking at refactoring the unit system in HA to be more coherent. Point is that a device type or attribute type should have the same unit all over HA. Another point with this is the possiblity to group entities and attributes by type and not by unit of measure. This is important eg when logging data into a db like influxdb. The |
I like using the |
Ok, how should I go about standardizing device_class? Issue tracking on the main home-assistant side, then start looking at the taxonomy there? |
I think that we should do like we did for binary sensor - grow as we go:
|
Going to close this PR as it's gone stale. The idea is still good, let's hope someone starts on it. |
This also updates the icon rotation direction based on the degrees
direction, which means that something like a wind sensor will have an
icon which is in a representative direction.