New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting aspect ratio in percentage #2289

merged 3 commits into from Dec 13, 2018


None yet
4 participants
Copy link

balloob commented Dec 13, 2018

We did not support setting aspect ration in %, I think this used to work as at least the map example in the Lovelace Gallery uses it.

Broken in 3rd example at

Fixed in <pending netlify>

@balloob balloob merged commit b3b9ca9 into dev Dec 13, 2018

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
WIP ready for review
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/push The Travis CI build passed
deploy/netlify Deploy preview ready!

@wafflebot wafflebot bot removed the in progress label Dec 13, 2018

@delete-merged-branch delete-merged-branch bot deleted the fix-aspect-ratio branch Dec 13, 2018

@balloob balloob added this to the 0.84.3 milestone Dec 16, 2018

balloob added a commit that referenced this pull request Dec 17, 2018

Fix setting aspect ratio in percentage (#2289)
* Fix setting aspect ratio in percentage

* Use endsWith

* Fix invalid test

This was referenced Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment