New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening edit dialog twice when closed by clicking on overlay #2290

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
3 participants
@balloob
Copy link
Member

balloob commented Dec 13, 2018

When the edit dialog was closed by clicking on the overlay, we didn't reset the state of the edit dialog manager. This meant that if we tried to open it again, it would render the same element, which meant it didn't need to change anything, and so also didn't reset opened.

Fixing by listening to when dialog is closed and calling cancel.

Fixes #2283

@bramkragten

This comment has been minimized.

Copy link
Member

bramkragten commented Dec 13, 2018

This was intentional at first, clicking cancel would cancel, clicking outside the dialog would close not cancel, opening the same again would get you on the same position as you left. On opening another element it updated.

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Dec 13, 2018

I don't think users expect such behavior.

@bramkragten

This comment has been minimized.

Copy link
Member

bramkragten commented Dec 13, 2018

I'm fine with this :) Idea was for clicking next to the dialog by accident.

@balloob balloob merged commit 71ed83e into dev Dec 13, 2018

5 checks passed

WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@delete-merged-branch delete-merged-branch bot deleted the fix-opening-edit-dialog-twice branch Dec 13, 2018

@wafflebot wafflebot bot removed the in progress label Dec 13, 2018

@balloob balloob added this to the 0.84.3 milestone Dec 16, 2018

@balloob balloob modified the milestone: 0.84.3 Dec 17, 2018

balloob added a commit that referenced this pull request Dec 17, 2018

This was referenced Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment