New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call super updated #2293

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
3 participants
@balloob
Copy link
Member

balloob commented Dec 13, 2018

Call super.updated(changedProps) from each updated function. This is necessary for the localize mixin to check if new translations have been downloaded and if so, generate a new this.localize function for the element and re-render it.

Fixes #2292

@zsarnett zsarnett merged commit 0dfca2f into dev Dec 13, 2018

5 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@delete-merged-branch delete-merged-branch bot deleted the call-super-updated branch Dec 13, 2018

@wafflebot wafflebot bot removed the in progress label Dec 13, 2018

@balloob balloob added this to the 0.84.3 milestone Dec 16, 2018

balloob added a commit that referenced this pull request Dec 17, 2018

This was referenced Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment