New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined on plant/weather card #2339

Merged
merged 1 commit into from Dec 16, 2018

Conversation

Projects
None yet
3 participants
@balloob
Copy link
Member

balloob commented Dec 16, 2018

When we added name support to the weather and plant card, we made the incorrect assumption that the config object would be passed in. This is not the case as that's a Lovelace object and this card is from the legacy UI.

Fixes #2301
Fixes #2294
Fixes #2297
Fixes #2318

@balloob balloob added this to the 0.84.3 milestone Dec 16, 2018

@wafflebot wafflebot bot added the in progress label Dec 16, 2018

@zsarnett zsarnett merged commit e20a02c into dev Dec 16, 2018

5 checks passed

WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@delete-merged-branch delete-merged-branch bot deleted the fix-undefined-config-legacy branch Dec 16, 2018

@wafflebot wafflebot bot removed the in progress label Dec 16, 2018

balloob added a commit that referenced this pull request Dec 17, 2018

This was referenced Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment