New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service button element #2343

Merged
merged 1 commit into from Dec 17, 2018

Conversation

Projects
None yet
2 participants
@balloob
Copy link
Member

balloob commented Dec 17, 2018

Service button element referred to an attribute name but was setting a property. Those names do not match in Polymer (kebab-case vs camelCase)

Fixes #2057

@wafflebot wafflebot bot added the in progress label Dec 17, 2018

@balloob balloob added this to the 0.84.3 milestone Dec 17, 2018

@balloob balloob merged commit e5bf842 into dev Dec 17, 2018

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
deploy/netlify Deploy preview ready!
Details

@delete-merged-branch delete-merged-branch bot deleted the fix-service-button-element branch Dec 17, 2018

@wafflebot wafflebot bot removed the in progress label Dec 17, 2018

balloob added a commit that referenced this pull request Dec 17, 2018

This was referenced Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment