New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap naming of error and system log on Dev Info panel #2668

Closed
wants to merge 1 commit into
base: dev
from

Conversation

Projects
None yet
3 participants
@AlecRust
Copy link
Contributor

AlecRust commented Feb 3, 2019

Current Problem

On the Dev Info panel user is shown the error log (in a <paper-card>) and then the "full system log" can be loaded underneath that.

However in the code these seem to be the other way around (the error log is called "system log" and the system log is called "error log").

There is also confusing copy such as referring to the error log when loading the system log:

screenshot

Solution

This swaps the naming around of these two panels in the code to reflect what they do. I've also added a heading to the error log card to make this clear:

screenshot

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Feb 3, 2019

I don't want to merge this. The names of the logs/cards/elements are based on the API that is called.

With system_health being introduced in 87, we're going to revamp the UI of this page anyway.

@balloob balloob closed this Feb 3, 2019

@wafflebot wafflebot bot removed the in progress label Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment