Tweak index.html #657
Tweak index.html #657
Conversation
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Cannot read config file: .eslintrc.json
Cannot read config file: .eslintrc.json
Error: ENOENT: no such file or directory, open '.eslintrc.json'
Referenced from: .eslintrc
Error: Cannot read config file: .eslintrc.json
at Object.fs.openSync (fs.js:652:18)
at Object.fs.readFileSync (fs.js:553:33)
at readFile (/app/node_modules/eslint/lib/config/config-file.js:64:15)
at loadJSONConfigFile (/app/node_modules/eslint/lib/config/config-file.js:114:41)
at loadConfigFile (/app/node_modules/eslint/lib/config/config-file.js:225:26)
at loadFromDisk (/app/node_modules/eslint/lib/config/config-file.js:530:18)
at load (/app/node_modules/eslint/lib/config/config-file.js:592:20)
at configExtends.reduceRight (/app/node_modules/eslint/lib/config/config-file.js:421:36)
at Array.reduceRight ()
at applyExtends (/app/node_modules/eslint/lib/config/config-file.js:403:28)
balloob
force-pushed
the
index-html-part-2
branch
from
141f357
to
48ae97f
Compare
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Cannot read config file: .eslintrc.json
Cannot read config file: .eslintrc.json
Error: ENOENT: no such file or directory, open '.eslintrc.json'
Referenced from: .eslintrc
Error: Cannot read config file: .eslintrc.json
at Object.fs.openSync (fs.js:652:18)
at Object.fs.readFileSync (fs.js:553:33)
at readFile (/app/node_modules/eslint/lib/config/config-file.js:64:15)
at loadJSONConfigFile (/app/node_modules/eslint/lib/config/config-file.js:114:41)
at loadConfigFile (/app/node_modules/eslint/lib/config/config-file.js:225:26)
at loadFromDisk (/app/node_modules/eslint/lib/config/config-file.js:530:18)
at load (/app/node_modules/eslint/lib/config/config-file.js:592:20)
at configExtends.reduceRight (/app/node_modules/eslint/lib/config/config-file.js:421:36)
at Array.reduceRight ()
at applyExtends (/app/node_modules/eslint/lib/config/config-file.js:403:28)
| const compatibilityPath = `/frontend_es5/compatibility-${md5(path.resolve(config.output_es5, 'compatibility.js'))}.js`; | ||
| const es5Extra = ` | ||
| <script src='${compatibilityPath}'></script> | ||
| <script src='/frontend_es5/custom-elements-es5-adapter.js'></script> |
There was a problem hiding this comment.
Does minifier inlines those 2 scripts?
It would be great if it did.
There was a problem hiding this comment.
I can add that. Should we inline core.js too?
There was a problem hiding this comment.
There are pros and cons:
On cold start it will save a round trip.
However index.html is fetched each time time to update cache, so by increasing this file we waste traffic.
Another option is to unite core+compatibility+adapter to a single file.
There was a problem hiding this comment.
Just realized that we can't combine custom-elements-es5-adapter.js with anything else. It will contain invalid syntax for older browsers which stops execution of the rest of the file.
|
I'm going ahead and merge this PR because the backend PR got merged. I'll open a PR with updates if any comments come in. |
Further optimizes the generation of index.html:
compatibility.jslink to a working urlcompatibility.js(to fix translations in iOS 9)compatibility.jsandcustom_elements_es5_adapter.jsin ES5 index.html.index.htmlBackend PR: home-assistant/core#10696
For the future, maybe we should combine
compatibility.jsandcustom_elements_es5_adapter.jsinto 1 file?