New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose entities for Google/Alexa #680

Merged
merged 7 commits into from Nov 6, 2018

Conversation

Projects
None yet
5 participants
@balloob
Member

balloob commented Nov 25, 2017

This ports the entity filter function from Home Assistant from Python to JavaScript. We will be able to use this function to power a user interface for exposing entities for Google Assistant, Emulated Hue, Alexa (as per #679)

Implemented function on the cloud dashboard.

Requires: home-assistant/home-assistant#18216

Show resolved Hide resolved test-mocha/common/util/entity_filter.js Outdated
Show resolved Hide resolved test-mocha/common/util/compute_state_domain.js Outdated
Show resolved Hide resolved js/util.js Outdated
Show resolved Hide resolved js/common/util/compute_state_display.js Outdated
Show resolved Hide resolved test-mocha/common/util/entity_filter.js Outdated
Show resolved Hide resolved test-mocha/common/util/compute_state_domain.js Outdated
Show resolved Hide resolved js/util.js Outdated
Show resolved Hide resolved js/common/util/compute_state_display.js Outdated
@houndci-bot

Some files could not be reviewed due to errors:

.eslintrc:
.eslintrc:
	Configuration for rule "import/extensions" is invalid:
	Severity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed '"always"').

Error: .eslintrc:
at validateRuleOptions (/app/node_modules/eslint/lib/config/config-validator.js:113:15)
at Object.keys.forEach.id (/app/node_modules/eslint/lib/config/config-validator.js:153:9)
at Array.forEach ()
at validateRules (/app/node_modules/eslint/lib/config/config-validator.js:152:30)
at Object.validate (/app/node_modules/eslint/lib/config/config-validator.js:230:5)
at loadFromDisk (/app/node_modules/eslint/lib/config/config-file.js:549:19)
at Object.load (/app/node_modules/eslint/lib/config/config-file.js:592:20)
at Config.getLocalConfigHierarchy (/app/node_modules/eslint/lib/config.js:226:44)
at Config.getConfigHierarchy (/app/node_modules/eslint/lib/config.js:180:43)
at Config.getConfigVector (/app/node_modules/eslint/lib/config.js:285:21)

@houndci-bot

Some files could not be reviewed due to errors:

.eslintrc:
.eslintrc:
	Configuration for rule "import/extensions" is invalid:
	Severity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed '"always"').

Error: .eslintrc:
at validateRuleOptions (/app/node_modules/eslint/lib/config/config-validator.js:113:15)
at Object.keys.forEach.id (/app/node_modules/eslint/lib/config/config-validator.js:153:9)
at Array.forEach ()
at validateRules (/app/node_modules/eslint/lib/config/config-validator.js:152:30)
at Object.validate (/app/node_modules/eslint/lib/config/config-validator.js:230:5)
at loadFromDisk (/app/node_modules/eslint/lib/config/config-file.js:549:19)
at Object.load (/app/node_modules/eslint/lib/config/config-file.js:592:20)
at Config.getLocalConfigHierarchy (/app/node_modules/eslint/lib/config.js:226:44)
at Config.getConfigHierarchy (/app/node_modules/eslint/lib/config.js:180:43)
at Config.getConfigVector (/app/node_modules/eslint/lib/config.js:285:21)

@@ -0,0 +1,88 @@
import entityFilter from '../../../js/common/util/entity_filter';

This comment has been minimized.

@houndci-bot

houndci-bot Nov 25, 2017

Missing file extension for "../../../js/common/util/entity_filter" import/extensions

Show resolved Hide resolved test-mocha/common/util/compute_state_domain.js Outdated
Show resolved Hide resolved js/util.js Outdated

@home-assistant home-assistant deleted a comment from houndci-bot Nov 25, 2017

@home-assistant home-assistant deleted a comment from houndci-bot Nov 25, 2017

@home-assistant home-assistant deleted a comment from houndci-bot Nov 25, 2017

@home-assistant home-assistant deleted a comment from houndci-bot Nov 25, 2017

@andrey-git

This comment has been minimized.

Contributor

andrey-git commented Nov 25, 2017

I think each new function should have at least one (non test) use

@andrey-git

This comment has been minimized.

Contributor

andrey-git commented Nov 25, 2017

Is the lint change specific for hound or is it relevant for local eslint too?

@balloob

This comment has been minimized.

Member

balloob commented Nov 25, 2017

I agree that we need non-test use. Waiting for #674 and #675 to land 👍 .

Eslint changes are relevant for local too.

@balloob balloob force-pushed the add-entity-filter branch from dfe22dc to 4eaba14 Nov 25, 2017

@balloob balloob force-pushed the add-entity-filter branch from 2afd23e to d6587cf Nov 25, 2017

@balloob

This comment has been minimized.

Member

balloob commented Nov 25, 2017

extracted eslint stuff.

@ciotlosm

This comment has been minimized.

Contributor

ciotlosm commented Jul 15, 2018

I assume this is no longer relevant?

@balloob

This comment has been minimized.

Member

balloob commented Jul 15, 2018

It is relevant but need to build UI that uses it. It is for Alexa and Google Assistant to decide what to expose.

@balloob balloob force-pushed the add-entity-filter branch from d6587cf to f149f93 Oct 12, 2018

@wafflebot wafflebot bot added the in progress label Oct 12, 2018

@balloob balloob force-pushed the add-entity-filter branch 2 times, most recently from 1907d28 to a0611c2 Oct 12, 2018

@balloob balloob changed the base branch from master to dev Oct 27, 2018

@balloob balloob force-pushed the add-entity-filter branch 2 times, most recently from 6cfd142 to 95eb6db Nov 4, 2018

@balloob balloob changed the title from Add entity filter util function to Expose entities for Google/Alexa Nov 5, 2018

@balloob

This comment has been minimized.

Member

balloob commented Nov 5, 2018

image

@balloob balloob referenced this pull request Nov 5, 2018

Merged

Cloud conf #18216

3 of 3 tasks complete
@balloob

This comment has been minimized.

Member

balloob commented Nov 5, 2018

Blocked by converting tests to TS first.

@balloob balloob referenced this pull request Nov 5, 2018

Merged

Ts all the tests #1998

@balloob balloob force-pushed the add-entity-filter branch from ddda31a to 93a6994 Nov 6, 2018

balloob added some commits Nov 25, 2017

Fix

@balloob balloob force-pushed the add-entity-filter branch from dcb1c02 to 960ef88 Nov 6, 2018

@balloob balloob merged commit e2b9893 into dev Nov 6, 2018

5 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@wafflebot wafflebot bot removed the in progress label Nov 6, 2018

@balloob balloob deleted the add-entity-filter branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment