Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit generation tool missing contributors #4703

Closed
mririgoyen opened this issue Feb 18, 2018 · 14 comments
Closed

Credit generation tool missing contributors #4703

mririgoyen opened this issue Feb 18, 2018 · 14 comments

Comments

@mririgoyen
Copy link
Contributor

The tool that generates the credits page doesn't seem to be including all contributors properly. For example, I contributed for the first time in the 0.61.0 release, but still have not been included in the list after several regenerations of the page.

I am unsure if others are missing as well.

@mririgoyen
Copy link
Contributor Author

Any word on this issue? It's been almost two months since I reported it and I still do not show up on the Credits page. :(

@flavio20002
Copy link
Contributor

Me too...I bet it's something about profile settings in github...

@fabaff
Copy link
Member

fabaff commented May 15, 2018

The script is iterating over the repos and grabbing the content. Not sure, about the profile settings. I can find something that looks like "Keep my details private".

@mririgoyen
Copy link
Contributor Author

I looked through my GitHub settings and don't see anything that would prevent my details from not being publicly available.

@stale
Copy link

stale bot commented Jul 14, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale The PR had no activity for quite some time, and is marked as Stale label Jul 14, 2018
@mririgoyen
Copy link
Contributor Author

This is not stale. I still do not appear.

@stale stale bot removed the Stale The PR had no activity for quite some time, and is marked as Stale label Jul 14, 2018
@frenck frenck self-assigned this Aug 13, 2018
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Aug 13, 2018
@frenck
Copy link
Member

frenck commented Aug 13, 2018

I'll give this a shot.

@fabaff
Copy link
Member

fabaff commented Sep 21, 2018

Both of you are still missing. I can't figure out why.

I think that we should integrate the credit script into hass-release as we have already most parts do the work in place there.

@frenck
Copy link
Member

frenck commented Sep 22, 2018

I've been playing on and off with it the past weeks and trying to "improve" it / getting it to work. Nevertheless, the hass-release might indeed be a better place for it.

@kariudo
Copy link

kariudo commented Sep 27, 2018

I have noticed I am also missing despite several regenerations since merged PRs. Couldn't spot any obvious reason as to why.

@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Sep 30, 2018
@frenck frenck removed their assignment Sep 30, 2018
@WofWca
Copy link
Contributor

WofWca commented Oct 5, 2018

Alright, this explains it, I guess:

only the first 500 author email addresses in the repository link to GitHub users. The rest will appear as anonymous contributors without associated GitHub user information.

Gotta find another way to obtain this data.

@stale
Copy link

stale bot commented Dec 4, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added Stale The PR had no activity for quite some time, and is marked as Stale and removed Stale The PR had no activity for quite some time, and is marked as Stale labels Dec 4, 2018
@nwesterhausen
Copy link
Contributor

nwesterhausen commented Dec 4, 2018

It seems to have all contributors listed. I see you on there as well.
image

I think this issue can be closed.

@fabaff
Copy link
Member

fabaff commented Dec 13, 2018

Yes, the new script should catch all now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants