Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update light.mqtt.markdown #8000

Merged
merged 3 commits into from Jan 15, 2019
Merged

Update light.mqtt.markdown #8000

merged 3 commits into from Jan 15, 2019

Conversation

dchesterton
Copy link
Contributor

Description:

Pull request in home-assistant (if applicable): home-assistant/core#19675

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Dec 31, 2018
@dchesterton dchesterton mentioned this pull request Dec 31, 2018
Merged
5 tasks
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration current This PR goes into the current branch has-parent This PR has a parent PR in a other repo needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch and removed to-do labels Dec 31, 2018
@frenck frenck changed the base branch from current to next December 31, 2018 14:00
@frenck frenck changed the base branch from next to current December 31, 2018 14:00
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Dec 31, 2018
@frenck
Copy link
Member

frenck commented Dec 31, 2018

@dchesterton, thank you for this PR!
The PR is against the wrong target base. It currently is targeted and based of the current branch. Since this PR has a code change pending, the documentation must go into the next branch, since it is depended on a future release of Home Assistant.

Please change the target branch to next and rebase the PR.

frenck
frenck requested changes Dec 31, 2018
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase onto next.

emontnemery
emontnemery previously requested changes Jan 1, 2019
View reviewed changes
source/_components/light.mqtt.markdown Outdated Show resolved Hide resolved
@dchesterton dchesterton changed the base branch from current to next January 1, 2019 21:01
@dchesterton
Copy link
Contributor Author

Thanks for the feedback. I've fixed the links and rebased onto next.

@frenck frenck changed the base branch from next to current January 15, 2019 20:56
@frenck frenck removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Jan 15, 2019
@frenck frenck dismissed emontnemery’s stale review January 15, 2019 20:58

comments addressed

@frenck
Copy link
Member

frenck commented Jan 15, 2019

Thanks, @dchesterton!
👍

@frenck frenck merged commit 43a9e06 into home-assistant:current Jan 15, 2019
@ghost ghost removed the in-progress This PR/Issue is currently being worked on label Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

@emontnemery emontnemery emontnemery left review comments

Assignees

@dchesterton dchesterton

Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dchesterton @frenck @emontnemery