Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Growatt sensor #8496

Open
wants to merge 5 commits into
base: next
from

Conversation

Projects
None yet
4 participants
@timvancann
Copy link
Contributor

commented Feb 12, 2019

Description:

Pull request in home-assistant (if applicable): home-assistant/home-assistant#21004

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Feb 12, 2019

@timvancann timvancann referenced this pull request Feb 12, 2019

Open

Growatt sensor #21004

9 of 9 tasks complete
Show resolved Hide resolved source/_components/sensor.growatt.markdown Outdated
Show resolved Hide resolved source/_components/sensor.growatt.markdown Outdated
@klaasnicolaas
Copy link
Contributor

left a comment

After this I will approve this PR and label it with awaits-parent

Show resolved Hide resolved source/_components/sensor.growatt.markdown Outdated
Show resolved Hide resolved source/_components/sensor.growatt.markdown Outdated

@frenck frenck removed their assignment Mar 7, 2019

@timvancann

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2019

@klaasnicolaas I've reverted you're suggested change as CI did not succeed. Also couldn't find any component that has multiple ha_categorys which makes me think it's not supported.

@ghost ghost assigned klaasnicolaas Mar 11, 2019

@klaasnicolaas

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

Will try it again 😉
There are a lot of components who also have this so it is certainly supported, as example

The build fails again but please do not change it now, other people will take a look on it.

@klaasnicolaas

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

You need to rebase your PR, I think your branch is to old.

@timvancann

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

@klaasnicolaas You were right, I had indeed neglected to rebase for a while now. It all seems good now. Thank you very much!

@timvancann timvancann force-pushed the timvancann:growatt-sensor branch 2 times, most recently from 9493f44 to 0d86c59 Mar 12, 2019

@klaasnicolaas

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

Great!

This PR can be merged as soon the parent PR is merged.

@timvancann timvancann force-pushed the timvancann:growatt-sensor branch from 02ebe90 to 5e0d7fd Apr 4, 2019

@timvancann timvancann force-pushed the timvancann:growatt-sensor branch from 5e0d7fd to bf9f0d3 Apr 27, 2019

@timvancann timvancann force-pushed the timvancann:growatt-sensor branch from bf9f0d3 to bd7b015 May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.