Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation for template binary_sensor #9106

Merged

Conversation

gadgetchnnel
Copy link
Contributor

@gadgetchnnel gadgetchnnel commented Apr 2, 2019

Description:
Added documentation for the new attribute_templates option for the template binary sensor.

Pull request in home-assistant (if applicable): home-assistant/core#22664

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Apr 2, 2019
@klaasnicolaas klaasnicolaas added has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch ready-for-review This PR needs to be reviewed and removed to-do labels Apr 2, 2019
klaasnicolaas
klaasnicolaas previously approved these changes Apr 2, 2019
@klaasnicolaas klaasnicolaas added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Apr 2, 2019
@stale
Copy link

stale bot commented Jun 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale The PR had no activity for quite some time, and is marked as Stale label Jun 1, 2019
@klaasnicolaas
Copy link
Member

Parent PR still open ⚠️ We have a merge conflict

@stale stale bot removed the Stale The PR had no activity for quite some time, and is marked as Stale label Jun 1, 2019
@frenck frenck added in-progress This PR/Issue is currently being worked on and removed awaits-parent Awaits the merge of an parent PR labels Jun 18, 2019
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @gadgetchnnel, a wild merge conflict appeared 😢

Could you please take a look and resolve it? Thanks already! 👍

frenck
frenck previously approved these changes Jun 18, 2019
@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Jun 18, 2019
@frenck
Copy link
Member

frenck commented Jun 18, 2019

Thanks for resolving the merge conflict so quickly @gadgetchnnel!
Awaiting parent PR now.

@frenck frenck added this to To Do in New documentation via automation Jun 28, 2019
@frenck frenck moved this from To Do to Awaiting Parent PR in New documentation Jun 28, 2019
@frenck frenck removed the awaits-parent Awaits the merge of an parent PR label Jul 18, 2019
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Jul 18, 2019
@frenck
Copy link
Member

frenck commented Jul 18, 2019

A wild merge conflict appeared again. @gadgetchnnel could you take a look? Thanks 👍

@frenck frenck added ready-for-review This PR needs to be reviewed and removed in-progress This PR/Issue is currently being worked on labels Jul 21, 2019
@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Aug 13, 2019
@probot-home-assistant probot-home-assistant bot added the parent-merged The parent PR has been merged already label Aug 21, 2019
@frenck
Copy link
Member

frenck commented Aug 21, 2019

Parent PR got merged! 🎉
Thanks for this @gadgetchnnel! 👍

@frenck frenck merged commit ef860a6 into home-assistant:next Aug 21, 2019
New documentation automation moved this from Awaiting Parent PR to Done Aug 21, 2019
@probot-home-assistant probot-home-assistant bot removed the parent-merged The parent PR has been merged already label Aug 21, 2019
@bbrendon bbrendon mentioned this pull request Sep 23, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants