Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netgear LTE binary sensors #9178

Merged
merged 3 commits into from Apr 9, 2019

Conversation

Projects
None yet
3 participants
@amelchio
Copy link
Contributor

amelchio commented Apr 9, 2019

Description:

  • Rewords aged introduction because we now have too many sensors to enumerate
  • Fixes a wrong default value
  • Moves some sensors to binary sensors (the linked parent PR)
  • Removes a couple of sections with no real content because I did not want to repeat it again for binary sensors

Pull request in home-assistant (if applicable): home-assistant/home-assistant#22902

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@wafflebot wafflebot bot added the ready-for-review label Apr 9, 2019

@amelchio amelchio referenced this pull request Apr 9, 2019

Merged

Binary sensors for netgear_lte #22902

9 of 9 tasks complete
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Add Binary Sensor to ha_category in front matter. I think that's a standard now that we add all platforms as categories. They will then show up in the component search.

Show resolved Hide resolved source/_components/netgear_lte.markdown Outdated
@klaasnicolaas

This comment has been minimized.

Copy link
Contributor

klaasnicolaas commented Apr 9, 2019

Can be merged after merging the parent PR 👍

@amelchio amelchio merged commit 63c9581 into home-assistant:next Apr 9, 2019

1 check passed

deploy/netlify Deploy preview ready!
Details

@wafflebot wafflebot bot removed the awaits-parent label Apr 9, 2019

@amelchio

This comment has been minimized.

Copy link
Contributor Author

amelchio commented Apr 9, 2019

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.