Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for trafikverket_train #9333

Merged
merged 20 commits into from Jun 28, 2019

Conversation

@endor-force
Copy link
Contributor

commented Apr 27, 2019

Description:
New component for trafikverket_train

Pull request in home-assistant (if applicable): home-assistant/home-assistant#23470

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.
endor-force added 2 commits Apr 27, 2019

@OverloadUT OverloadUT added the to-do label Apr 27, 2019

@endor-force endor-force referenced this pull request Apr 27, 2019
10 of 10 tasks complete
endor-force and others added 4 commits Apr 28, 2019
@frenck
Copy link
Member

left a comment

Hi @endor-force, this PR is currently failing the build tests. Could you take a look and make sure the build passes? Thanks already! 👍

Don't use !secret in example
Co-Authored-By: Klaas Schoute <klaas_schoute@hotmail.com>
@frenck
Copy link
Member

left a comment

Some small typo changes

source/_components/trafikverket_train.markdown Outdated Show resolved Hide resolved
source/_components/trafikverket_train.markdown Outdated Show resolved Hide resolved
source/_components/trafikverket_train.markdown Outdated Show resolved Hide resolved
source/_components/trafikverket_train.markdown Outdated Show resolved Hide resolved
source/_components/trafikverket_train.markdown Outdated Show resolved Hide resolved
source/_components/trafikverket_train.markdown Outdated Show resolved Hide resolved
source/_components/trafikverket_train.markdown Outdated Show resolved Hide resolved
source/_components/trafikverket_train.markdown Outdated Show resolved Hide resolved
source/_components/trafikverket_train.markdown Outdated Show resolved Hide resolved
endor-force and others added 9 commits Jun 19, 2019
Fix typo
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Fix typo
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Fix typo
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Fix typo
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Fix typo
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Fix typo
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Fix typo
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Fix typo
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Fix typo
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@frenck
Copy link
Member

left a comment

Approved. Can be merged as soon as the parent PR gets merged.
⚠️ The ha_release might need an update before merging this one in.

@frenck frenck added awaits-parent and removed in-progress labels Jun 19, 2019

@endor-force endor-force changed the title Added documentation for trafikverket_train Add documentation for trafikverket_train Jun 20, 2019

@frenck frenck added this to To Do in New documentation via automation Jun 28, 2019

@frenck frenck removed the awaits-parent label Jun 28, 2019

@frenck frenck moved this from To Do to Parent Merged in New documentation Jun 28, 2019

@frenck frenck dismissed their stale review via 4c60072 Jun 28, 2019

@frenck
frenck approved these changes Jun 28, 2019

Comments addressed.

New documentation automation moved this from Parent Merged to Awaiting Parent PR Jun 28, 2019

@frenck frenck moved this from Awaiting Parent PR to Parent Merged in New documentation Jun 28, 2019

@frenck frenck merged commit 727b1bb into home-assistant:next Jun 28, 2019

1 check passed

deploy/netlify Deploy preview ready!
Details

New documentation automation moved this from Parent Merged to Done Jun 28, 2019

@frenck frenck removed the parent-merged label Jun 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.