Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSMR regression on dev branch #21730

Closed
wburgers opened this Issue Mar 7, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@wburgers
Copy link
Contributor

wburgers commented Mar 7, 2019

Home Assistant release with the issue:

dev branch

Last working Home Assistant release (if known):
0.88.2

Operating environment (Hass.io/Docker/Windows/etc.):

Component/platform:

https://www.home-assistant.io/components/sensor.dsmr/

Description of problem:
After my PR, I broke the sensor.
See this comment: #21620 (comment)

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):


Additional information:
I have already made a fix and will create a PR within the hour.

@wburgers wburgers referenced this issue Mar 7, 2019

Merged

Fix TypeError #21734

3 of 9 tasks complete

@wafflebot wafflebot bot added the in progress label Mar 7, 2019

@awarecan

This comment has been minimized.

Copy link
Contributor

awarecan commented Mar 7, 2019

#21620 is not in 0.89 release. I am going to change issue title to reflect it.

@awarecan awarecan changed the title DSMR regression after 0.89.0 DSMR regression on dev branch Mar 7, 2019

@wburgers

This comment has been minimized.

Copy link
Contributor Author

wburgers commented Mar 7, 2019

I was already worried I broke this for many people.
Thnx @awarecan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.