Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tado fixes #11294

Merged
merged 3 commits into from Feb 3, 2018

Conversation

Projects
None yet
6 participants
@NigelRook
Copy link
Contributor

commented Dec 24, 2017

Description:

Previously, when tado ended an overlay state itself, say because a timer expired or a scheduled temperature change ocurred, the tado climate
component would not return to Smart Schedule mode. This change fixes that issue

Previosuly, making two changes to tado climate within 10 seconds, for example setting operation mode to Tado mode, then changing the temperature, would leave the entity showing the incorrect state for up to a minute. This change forces an unthrottled update after setting the climate state, which fixes the issue

Related issue (if applicable): None reported

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

NigelRook added some commits Dec 24, 2017

Fix tado overlay end state
Previously, when tado ended an overlay state itself, say because a timer
expired or a scheduled temperature change ocurred, the tado climate
component would not return to Smart Schedule mode. This change fixes
that issue
Correct tado state after multiple rapid updates
Previosuly, making two changes to tado climate within 10 seconds, for
example setting operation mode to Tado mode, then changing the
temperature, would leave the entity showing the incorrect state for up
to a minute.

This change forces an unthrottled update after setting the climate
state, which fixes the issue
@homeassistant

This comment has been minimized.

Copy link

commented Dec 24, 2017

Hi @NigelRook,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!


def set_zone_overlay(self, zone_id, mode, temperature=None, duration=None):
"""Wrap for setZoneOverlay(..)."""
return self.tado.setZoneOverlay(zone_id, mode, temperature, duration)
self.tado.setZoneOverlay(zone_id, mode, temperature, duration)
self.update(no_throttle=True) #pylint: disable=unexpected-keyword-arg

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 24, 2017

at least two spaces before inline comment
inline comment should start with '# '

@@ -119,8 +119,10 @@ def get_me(self):

def reset_zone_overlay(self, zone_id):
"""Wrap for resetZoneOverlay(..)."""
return self.tado.resetZoneOverlay(zone_id)
self.tado.resetZoneOverlay(zone_id)
self.update(no_throttle=True) #pylint: disable=unexpected-keyword-arg

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 24, 2017

at least two spaces before inline comment
inline comment should start with '# '


def set_zone_overlay(self, zone_id, mode, temperature=None, duration=None):
"""Wrap for setZoneOverlay(..)."""
return self.tado.setZoneOverlay(zone_id, mode, temperature, duration)
self.tado.setZoneOverlay(zone_id, mode, temperature, duration)
self.update(no_throttle=True) #pylint: disable=unexpected-keyword-arg

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 24, 2017

at least two spaces before inline comment
inline comment should start with '# '

@@ -119,8 +119,10 @@ def get_me(self):

def reset_zone_overlay(self, zone_id):
"""Wrap for resetZoneOverlay(..)."""
return self.tado.resetZoneOverlay(zone_id)
self.tado.resetZoneOverlay(zone_id)
self.update(no_throttle=True) #pylint: disable=unexpected-keyword-arg

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 24, 2017

at least two spaces before inline comment
inline comment should start with '# '

@homeassistant homeassistant added cla-signed and removed cla-needed labels Dec 24, 2017

@pvizeli

This comment has been minimized.

Copy link
Member

commented Dec 25, 2017

Please add a description what you change will do and why you want have this

@balloob

balloob approved these changes Feb 3, 2018

@balloob

This comment has been minimized.

Copy link
Member

commented Feb 3, 2018

Thanks! 🌮

@balloob balloob merged commit c204a7c into home-assistant:dev Feb 3, 2018

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 94.066%
Details
hound No violations found. Woof!

@balloob balloob referenced this pull request Feb 9, 2018

Merged

0.63 #12267

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.