Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding information about current TV channel to WebOS media player #11339

Merged
merged 4 commits into from Feb 2, 2018

Conversation

Projects
None yet
6 participants
@led-spb
Copy link
Contributor

commented Dec 28, 2017

Description:

This update added display information about current TV channel for WebOS devices. Information about current channel is stored in media_title attribute.

Checklist:

  • Local tests with tox run successfully.
@homeassistant

This comment has been minimized.

Copy link

commented Dec 28, 2017

Hi @led-spb,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@property
def media_title(self):
"""Title of current playing media."""
return self._channel['channelName'] if (self._channel!=None) and ('channelName' in self._channel) else None

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 28, 2017

comparison to None should be 'if cond is not None:'
missing whitespace around operator
line too long (115 > 79 characters)

@@ -263,6 +267,11 @@ def media_content_type(self):
"""Content type of current playing media."""
return MEDIA_TYPE_CHANNEL

@property

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 28, 2017

trailing whitespace

@homeassistant homeassistant added cla-signed and removed cla-needed labels Dec 28, 2017

@moskovskiy82

This comment has been minimized.

Copy link

commented Jan 27, 2018

Is this commit ever going to be reviewed and merged?

@tschmidty69

This comment has been minimized.

Copy link
Contributor

commented Jan 27, 2018

Looks fine to me.

@tschmidty69 tschmidty69 self-requested a review Jan 27, 2018

@fabaff fabaff merged commit a3e36e6 into home-assistant:dev Feb 2, 2018

4 checks passed

cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.006%) to 94.068%
Details
hound No violations found. Woof!

@balloob balloob referenced this pull request Feb 9, 2018

Merged

0.63 #12267

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.