Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mypy command line arguments #11638

Merged
merged 1 commit into from Jan 15, 2018

Conversation

Projects
None yet
3 participants
@benleb
Copy link
Contributor

commented Jan 14, 2018

Description:

mypy complains about deprecated command line arguments. I fixed them according to the warning.

Warning: --silent-imports has been replaced by --ignore-missing-imports --follow-imports=skip

Related issue (if applicable): -

Pull request in home-assistant.github.io with documentation (if applicable): -

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link

commented Jan 14, 2018

Hi @benleb,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@fabaff

fabaff approved these changes Jan 15, 2018

Copy link
Member

left a comment

Thanks 🐦

@fabaff fabaff merged commit bf3329e into home-assistant:dev Jan 15, 2018

4 checks passed

cla-bot All contributors have signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.006%) to 93.899%
Details
hound No violations found. Woof!

@benleb benleb deleted the benleb:mypy-arguments branch Jan 21, 2018

@balloob balloob referenced this pull request Jan 26, 2018

Merged

0.62 #11921

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.