Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond to Alexa scene activation correctly #11869

Merged
merged 1 commit into from Jan 23, 2018
Merged

Conversation

@bitglue
Copy link
Member

bitglue commented Jan 23, 2018

Description:

The API documentation specifies that Alexa.SceneController Activate
must get a ActivationStarted response. Responding with just a Response
will elicit a "Hmm... $scene is not responding" from Alexa.

Checklist:

  • The code change is tested and works locally.
  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.
The API documentation[1] specifies that Alexa.SceneController Activate
must get a ActivationStarted response. Responding with just a `Response`
will elicit a "Hmm... $scene is not responding" from Alexa.

[1]: https://developer.amazon.com/docs/smarthome/provide-scenes-in-a-smart-home-skill.html
@bitglue bitglue force-pushed the bitglue:scene branch to f35e711 Jan 23, 2018
@philk philk mentioned this pull request Jan 23, 2018
@philk

This comment has been minimized.

Copy link
Contributor

philk commented Jan 23, 2018

YES, thank you! I spent an hour or so last weekend poking around to see if I could figure out why this was broken and had no luck (guess it helps to read the docs more thoroughly...😅). Cherry-picked this change and it's working great.

@balloob balloob merged commit 95592d9 into home-assistant:dev Jan 23, 2018
5 checks passed
5 checks passed
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 93.85%
Details
hound No violations found. Woof!
hmn added a commit to hmn/home-assistant-dev that referenced this pull request Jan 23, 2018
* dev:
  Checking Xiaomi Aqara devices unavailability states (home-assistant#11631)
  Respond to Alexa scene activation correctly (home-assistant#11869)
  BME680 Sensor Component (home-assistant#11695)
  Allow exposing sensors as temperature or humidity 'climate' devices to Google Assistant (home-assistant#11095)
  Clean up entity component (home-assistant#11691)
@bitglue

This comment has been minimized.

Copy link
Member Author

bitglue commented Jan 23, 2018

@philk I've found https://github.com/alexa/alexa-smarthome/tree/master/sample_messages to be the most helpful resource for such things.

@balloob balloob mentioned this pull request Jan 26, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.