Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for samsungtv #11933

Merged
merged 2 commits into from Feb 3, 2018

Conversation

Projects
None yet
5 participants
@kennedyshead
Copy link
Contributor

commented Jan 26, 2018

  • The code change is tested and works locally.
  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
self.device.send_key("HELLO")
self.assertIsNone(self.device._remote)
self.assertEqual(STATE_ON, self.device._state)

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 1, 2018

blank line at end of file

This comment has been minimized.

Copy link
@kennedyshead

kennedyshead Feb 1, 2018

Author Contributor

?

tests/components/media_player/test_samsungtv.py Outdated
with mock.patch(
'homeassistant.components.media_player.samsungtv.socket'):
add_devices = mock.Mock()
setup_platform(self.hass,{}, add_devices,

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 1, 2018

missing whitespace after ','

@kennedyshead kennedyshead changed the title [WIP] Tests for samsungtv Tests for samsungtv Feb 1, 2018

@tschmidty69

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2018

See no reason not to merge tests. Tests are cool. Unlike fezes and bow ties.

@tschmidty69 tschmidty69 merged commit 8fe339d into home-assistant:dev Feb 3, 2018

5 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 93.894%
Details
hound No violations found. Woof!

@kennedyshead kennedyshead deleted the kennedyshead:test_samsungtv branch Feb 4, 2018

@balloob balloob referenced this pull request Feb 9, 2018

Merged

0.63 #12267

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.