Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panasonic viera new services #11963

Merged
merged 7 commits into from Feb 3, 2018

Conversation

Projects
None yet
5 participants
@dgomes
Copy link
Contributor

commented Jan 27, 2018

Description:

This pull requests implements two missing services:

  • play_media
  • media_stop

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4530

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

dgomes added some commits Jan 27, 2018

Implemented play_media
Panasonic Viera TV has a full blown Web Browser that can play any media
@tschmidty69

This comment has been minimized.

Copy link
Contributor

commented Jan 27, 2018

You need to add SUPPORT_PLAY_MEDIA and SUPPORT_STOP to expose the services.

What about the other media types? Are they supported and if so can they be added?

@dgomes

This comment has been minimized.

Copy link
Contributor Author

commented Jan 27, 2018

@tschmidty69 tks for the heads up!

I was testing successfully and didn't notice the need for it.

Other media types are reproducible using Apps (installed from an app store) in the TV, these require installation so I though it would not make much sense to make it part of the component...

The web browser is pre-installed, as well as the Netflix app. I would like to launch Netflix as a HA service but see no obvious mapping to existing services...

@dgomes dgomes changed the title [Panasonic viera] new services Panasonic viera new services Jan 27, 2018

@dgomes dgomes requested a review from andrey-git as a code owner Jan 27, 2018

@dgomes dgomes referenced this pull request Feb 1, 2018

Merged

Update panasonic_viera to 0.3 #11989

3 of 9 tasks complete
try:
self._remote.open_webpage(media_id)
except (TimeoutError, OSError):
self._state = STATE_OFF

This comment has been minimized.

Copy link
@rytilahti

rytilahti Feb 3, 2018

Contributor

You want potentially add an else statement here with some logging in case media_type is something else than expected, I think a warning would do fine to let someone looking into the logs to see what is happening.

This comment has been minimized.

Copy link
@dgomes

dgomes Feb 3, 2018

Author Contributor

Done!

_LOGGER.warning("Unsupported media_type: %s", media_type)


def media_stop(self):

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 3, 2018

too many blank lines (2)

@tschmidty69

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2018

Looks good to me.

@tschmidty69 tschmidty69 merged commit b33d893 into home-assistant:dev Feb 3, 2018

5 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 93.94%
Details
hound No violations found. Woof!

@balloob balloob referenced this pull request Feb 9, 2018

Merged

0.63 #12267

@dgomes dgomes deleted the dgomes:panasonic_viera_open_url branch Feb 12, 2018

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.