Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 35 #11972

Merged
merged 3 commits into from Jan 29, 2018

Conversation

@scop
Copy link
Contributor

commented Jan 27, 2018

Description:

Upgrade flake8 to 3.5, address new errors.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@scop scop force-pushed the scop:flake8-35 branch to e6764a5 Jan 27, 2018

@balloob

This comment has been minimized.

Copy link
Member

commented Jan 29, 2018

PyLint is not liking the fixes.

@scop

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2018

Hopefully fixed now.

@balloob

This comment has been minimized.

Copy link
Member

commented Jan 29, 2018

🐬 all good. One flaky test failed, but that's fine.

@balloob balloob merged commit 78a3c01 into home-assistant:dev Jan 29, 2018

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
coverage/coveralls Coverage decreased (-0.04%) to 93.861%
Details
hound No violations found. Woof!

@scop scop deleted the scop:flake8-35 branch Jan 29, 2018

@balloob balloob referenced this pull request Feb 9, 2018

Merged

0.63 #12267

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.