Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update panasonic_viera to 0.3 #11989

Merged
merged 1 commit into from Jan 28, 2018

Conversation

Projects
None yet
4 participants
@scop
Copy link
Contributor

commented Jan 28, 2018

Description:

Update panasonic_viera to 0.3.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.
@fabaff

fabaff approved these changes Jan 28, 2018

Copy link
Member

left a comment

🐦

@fabaff fabaff merged commit a3fc2c7 into home-assistant:dev Jan 28, 2018

5 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.896%
Details
hound No violations found. Woof!

@scop scop deleted the scop:viera-0.3 branch Jan 28, 2018

@dgomes

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2018

@fabaff

Since I was the original contributor to panasonic_viera that pushed version 0.2 to 0.3 (florianholzapfel/panasonic-viera#4) for the purpose of my PR #11963

Can you at least review #11963 ?

@balloob balloob referenced this pull request Feb 9, 2018

Merged

0.63 #12267

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.