Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online state for samsungtv is jumping when TV is idle #11998

Merged
merged 2 commits into from Jan 29, 2018
Merged

Online state for samsungtv is jumping when TV is idle #11998

merged 2 commits into from Jan 29, 2018

Conversation

kennedyshead
Copy link
Contributor

Description:

TV

Checklist:

  • The code change is tested and works locally.
  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@MartinHjelmare
Copy link
Member

Please add an explanation to how the code change solves the problem.

@kennedyshead
Copy link
Contributor Author

The problem is actually the way the socket works on the different samsung models, I have 2 different samsung tv:s and one of them open the UDP port in idle as-well. the other one does not and only opens up the port when its on.

Ping on the other hand works on both tv:s and they respond.

However, Im not sure on if this works on all models.

The original implementation just sent a dummy command to the tv, which worked with some of them but not any of mine (It have worked earlier).

I have:
UE40F5505
and
UE60KS7005

Both works flawless with ping for fetching online state. (All other enabled buttons works as well).

@kennedyshead
Copy link
Contributor Author

I would however like to do this through device_tracker (if precent in setup).
This actually goes for more devices, but I cant figure out how to implement that at this time.

@ajmm
Copy link

ajmm commented Jan 29, 2018

tested and works ok for me!

@balloob balloob merged commit 7ad870c into home-assistant:dev Jan 29, 2018
@kennedyshead kennedyshead deleted the samsungtv_timeout_offline branch February 1, 2018 16:11
@pplucky
Copy link

pplucky commented Feb 8, 2018

This actually fixed the on/off status not being shown properly, but now I can no longer turn off the tv... Can anyone check/confirm please?

@kennedyshead
Copy link
Contributor Author

@pplucky please create an issue

@balloob balloob mentioned this pull request Feb 9, 2018
@pratesbh
Copy link

@pplucky I confirm that I also can't turn off off or send any command to my Samsung UN46D5500 TV.

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants