Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DoorBird push notifications for HA instances with an API password #12020

Merged
merged 1 commit into from Jan 29, 2018

Conversation

Projects
None yet
3 participants
@Klikini
Copy link
Contributor

commented Jan 28, 2018

Description:

Due to testing only on a Home Assistant instance without an API password, I previously overlooked the necessity of the endpoint to accept requests from a DoorBird without authentication.

This change removes the requirement for authentication on calls /api/doorbird/doorbell.

Related issue (if applicable): https://community.home-assistant.io/t/doorbird-integration/5564/50

Checklist:

  • The code change is tested and works locally.

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@pvizeli pvizeli merged commit 12a53e2 into home-assistant:dev Jan 29, 2018

5 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 93.899%
Details
hound No violations found. Woof!

@balloob balloob referenced this pull request Feb 9, 2018

Merged

0.63 #12267

@Klikini Klikini deleted the Klikini:doorbird-auth-fix branch Mar 3, 2018

@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.