Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract requirements #12051

Merged
merged 1 commit into from Jan 30, 2018

Conversation

Projects
None yet
4 participants
@balloob
Copy link
Member

commented Jan 30, 2018

Description:

Minor cleanup of our setup process:

  • Extract Hass requirements code into its own file
  • Only check dependencies and requirements for each component/platform once

Checklist:

  • The code change is tested and works locally.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Jan 30, 2018

@pvizeli

This comment has been minimized.

Copy link
Member

commented Jan 30, 2018

🐬

@pvizeli pvizeli merged commit ec1c395 into dev Jan 30, 2018

6 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 93.887%
Details
hound No violations found. Woof!

@pvizeli pvizeli deleted the setup-cleanup branch Jan 30, 2018

@MartinHjelmare
Copy link
Member

left a comment

Requirements are no longer installed directly in deps directory but in the library folder under the deps directory. That path is given by mounting the local lib path.

'constraints': os.path.join(os.path.dirname(__file__), CONSTRAINT_FILE)
}
if not pkg_util.running_under_virtualenv():
kwargs['target'] = os.path.join(config_dir, 'deps')

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Jan 30, 2018

Member

This is changing the target path. Target should be the library folder.

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Jan 30, 2018

Member

Nevermind, I'm wrong and remembered incorrectly.

This was referenced Feb 9, 2018

@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.