Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python_openzwave update config service #12060

Merged
merged 4 commits into from May 2, 2018

Conversation

perosb
Copy link
Contributor

@perosb perosb commented Jan 30, 2018

Description:

Adds a service that can invoke the update function in python_openzwave.
That method downloads and updates the configuration files from github.

Note though that it uses os.system "cp -r", not sure that will work for windows. (if windows even is supported)

Checklist:

  • The code change is tested and works locally.

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@tschmidty69
Copy link
Contributor

Definitely won't run on windows. Odd that he used os.system('cp') instead of shutl.copytree considering he used shutil.rmtree just below it. Not sure about the default flavor at this point. Should also wait for the version number to be updated in your other PR.

@tschmidty69
Copy link
Contributor

I am not as concerned over the windows bit (althought would be easy to open a pr or issue for that over at python-openzwave). I'd like a core dev to comment on the idea of downloading a zip file over. I also think at this point, he may be on board with an automated pypi build, which would be nice.

So with the configs updated with your other PR, I am going to mark this as a WIP for a week or two to see if he is releasing new versions regularly.

@tschmidty69 tschmidty69 changed the title python_openzwave update config service WIP: python_openzwave update config service Feb 3, 2018
@SebasT87
Copy link

SebasT87 commented Feb 3, 2018

Another version has been released so it seems he’s auto releasing everyday

@PRabahy
Copy link
Contributor

PRabahy commented Feb 26, 2018

Looks like there haven't been any releases (https://github.com/OpenZWave/python-openzwave/releases) in 22 days, so I'm guessing that it isn't going to get automatic daily releases.

@ghost
Copy link

ghost commented Apr 7, 2018

Looks like a good solution, why still in WIP ?

@perosb perosb changed the title WIP: python_openzwave update config service python_openzwave update config service Apr 14, 2018
@perosb
Copy link
Contributor Author

perosb commented Apr 14, 2018

Removed WIP and hopefully someone can take a look at getting this merged.
@tschmidty69 or @andrey-git

@balloob balloob merged commit 351e892 into home-assistant:dev May 2, 2018
@balloob balloob mentioned this pull request May 11, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
@perosb perosb deleted the ozw-update-config branch March 10, 2019 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants