New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python_openzwave update config service #12060
Conversation
Definitely won't run on windows. Odd that he used os.system('cp') instead of shutl.copytree considering he used shutil.rmtree just below it. Not sure about the default flavor at this point. Should also wait for the version number to be updated in your other PR. |
I am not as concerned over the windows bit (althought would be easy to open a pr or issue for that over at python-openzwave). I'd like a core dev to comment on the idea of downloading a zip file over. I also think at this point, he may be on board with an automated pypi build, which would be nice. So with the configs updated with your other PR, I am going to mark this as a WIP for a week or two to see if he is releasing new versions regularly. |
Another version has been released so it seems he’s auto releasing everyday |
Looks like there haven't been any releases (https://github.com/OpenZWave/python-openzwave/releases) in 22 days, so I'm guessing that it isn't going to get automatic daily releases. |
Looks like a good solution, why still in WIP ? |
Removed WIP and hopefully someone can take a look at getting this merged. |
Description:
Adds a service that can invoke the update function in python_openzwave.
That method downloads and updates the configuration files from github.
Note though that it uses os.system "cp -r", not sure that will work for windows. (if windows even is supported)
Checklist:
If the code communicates with devices, web services, or third-party tools:
tox
run successfully. Your PR cannot be merged unless tests pass